igvm_c/Makefile: add CFLAGS, LDFLAGS, CC and .PHONY targets #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace cc with $(CC) so that it can be changed externally. Introduce CFLAGS and LDFLAGS for dump_igvm and igvm_test. Remove libm from dump_igvm as is not required. Signed-off-by: Luigi Leonardi <leonardi@redhat.com>
.PHONY does not include targets that are not file names like `build` or `all`. Signed-off-by: Luigi Leonardi <leonardi@redhat.com>
luigix25
changed the title
Member
|
Do you want a new release for this on github/crates.io? |
chris-oo
approved these changes
Jun 6, 2025
Contributor
Author
|
Don't worry, no need to! Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-g3 -O0to CFLAGS and-L $(TARGET_PATH)to LDFLAGSDESTDIR ?=FYI: igvm is on its way to be approved as a static library in Fedora